帮我看看程序错在哪.

tian1118

uname -a
Linux nxgzserver 2.4.21-4.ELsmp #1 SMP Fri Oct 3 17:52:56 EDT 2003 i686 i686 i386 GNU/Linux

cc 1.c
1.c: In function `save2file':
1.c:64: warning: assignment makes pointer from integer without a cast

cat 1.c
#include <stdio.h>
#include <malloc.h>
#include <string.h>

struct fapiao{
  char fp[30];
  struct fapiao *next;
};
typedef struct fapiao FAPIAO;

main()
{
char fpstr[30];
FAPIAO *head;

void insert(FAPIAO **,char *);
void save2file(FAPIAO **,char *);

head=NULL;
while (1)
{
   printf("Please enter the fapiao serial number,exit program with string \"exit\":\n");
   scanf("%s",fpstr);
   if (strcmp(fpstr,"exit")==0) break;
   insert(&head,fpstr);
}
printf("Please enter the file name for save datas:\n");
scanf("%s",fpstr);
save2file(&head,fpstr);
}

void insert(FAPIAO **head,char *string)
{
  FAPIAO *cur,*pre,*new;
   
  if ((new=(FAPIAO *)malloc(sizeof(FAPIAO)))==NULL)
     {printf("Can't creat new node!\n");return;}
  strcpy(new->fp,string);
  new->next=NULL;
  pre=*head;
  if (pre==NULL)
     *head=new;
  else
     {cur=pre;
      while(cur!=NULL)
         {if(strcmp(string,cur->fp)==0)
             {printf("Repeated!\n");return;}
          pre=cur;
          cur=cur->next;
         }
      pre->next=new;
      return;
     }
}

void save2file(FAPIAO **head,char *string)
{
FAPIAO *cur,*pre;
FILE *fptr;

pre=*head;
if (pre==NULL) return;
cur=pre;
if (fptr=fopen(string,"w")==NULL)
   {printf("Can't creat file!\n");return;}
while (cur!=NULL)
  {fprintf(fptr,"%30s\n",cur->fp);
     *head=cur;
     cur=cur->next;
     free(pre);
     pre=*head;
  }

fclose(fptr);
return;
}

tian1118

cc 1.c
1.c: In function `save2file':
1.c:64: warning: assignment makes pointer from integer without a cast
ls
1~  1.c  1.c~  1.sh  1.sh~  a.out  bin  Desktop  first  mv  string  study  公证登记表
./a.out
Please enter the fapiao serial number,exit program with string "exit":
1
Please enter the fapiao serial number,exit program with string "exit":
2
Please enter the fapiao serial number,exit program with string "exit":
3
Please enter the fapiao serial number,exit program with string "exit":
4
Please enter the fapiao serial number,exit program with string "exit":
3
Repeated!
Please enter the fapiao serial number,exit program with string "exit":
exit
Please enter the file name for save datas:
ttt
段错误
[root--680--~]ls
1~  1.c  1.c~  1.sh  1.sh~  a.out  bin  Desktop  first  mv  string  study  ttt  公证登记表
[root--681--~]cat ttt
[root--682--~]
ttt为空

alpher

if (fptr=fopen(string,"w")==NULL)
应该是
if (fptr=fopen(string,"w")==0)
而且，这种写法是很不好的习惯

alpher

void save2file(FAPIAO **head,char *string)
{
FAPIAO *cur,*pre;
FILE *fptr;

pre=*head;
if (pre==NULL) return;
cur=pre;
if (fptr=fopen(string,"w")==NULL)
{printf("Can't creat file!\n");return;}
while (cur!=NULL)
{fprintf(fptr,"%30s\n",cur->fp);
/*   *head=cur;  */
cur=cur->next;
free(pre);
/*   pre=*head;  */
pre=cur;
}

alpher

不过哪里出错，我也不确定
呵呵

yohji

我看是优先级的问题:
第64行改为:
if ((fptr=fopen(string,"w"))==NULL)
PS:
new在c++里是关键字,不要用它作变量名.

typedef struct fapiao FAPIAO;
这种风格我以前也用过,不过现在用这种了:
typedef struct fapiao fapiao_t;
typedef fapiao_t* p_fapiao_t;

void类型的函数往往不是很好的选择,试一下int来代替,成功是返回0,出错时返回-1,并设置出错信息.

而且把main函数放最后是不错的选择!^_^